thisconnect

collaborative music software in real-time

  1. @thisconnect thisconnect commented on BitBoxSwiss/bitbox-wallet-app#3666 · November 4, 2025 11:52
  2. @thisconnect thisconnect pushed to frontend-responsive-fontsize-android in thisconnect/bitbox-wallet-app · November 4, 2025 07:47
    2 commits to frontend-responsive-fontsize-android
    • @thisconnect ee8e801
      frontend: cleanup and remove sidebar-header-size css variable
    • @thisconnect ec121d9
      frontend: cleanup and remove sidebar-header-line-heigh css variable
    • 19 more commits »
  3. @thisconnect thisconnect commented on BitBoxSwiss/bitbox-wallet-app#3664 · November 3, 2025 09:32
    old version conditionally hide this row in case `transactionInfo.amountAtTime?.estimated === false`
  4. @thisconnect thisconnect commented on BitBoxSwiss/bitbox-wallet-app#3664 · November 3, 2025 09:27
    old version checked for `transactionInfo.fee && transactionInfo.fee.amount` with fallback to `---`, but I fogrot exactly when this is needed.
  5. @thisconnect thisconnect commented on BitBoxSwiss/bitbox-wallet-app#3664 · November 3, 2025 09:26
    The old version rendered transactionInfo.weight, transactionInfo.vsize, transactionInfo.size conditionally if their value was truthy. IIrc altcoins…
  6. @thisconnect thisconnect commented on BitBoxSwiss/bitbox-wallet-app#3664 · November 3, 2025 09:21
    In button.send and button.receive, we already have these, maybe a good moment to unify and move to generic.send and generic.recieve?
  7. @thisconnect thisconnect commented on BitBoxSwiss/bitbox-wallet-app#3664 · November 3, 2025 09:18
    is withTooltip needed?
  8. @thisconnect thisconnect commented on BitBoxSwiss/bitbox-wallet-app#3664 · November 3, 2025 09:11
    currently accordion is only use in advacne-tx-detail.tsx, but the open state could be handled only internally or externally. Why support both? (I s…
  9. @thisconnect thisconnect commented on BitBoxSwiss/bitbox-wallet-app#3664 · November 3, 2025 08:51
    Nit: could you change to use react children instead of content prop?
  10. @thisconnect thisconnect commented on BitBoxSwiss/bitbox-wallet-app#3664 · November 3, 2025 08:46
    I think flexibleHeight prop is for multi line textareas and not needed here as it should be only 1 line.
  11. @thisconnect thisconnect pushed to master in BitBoxSwiss/bitbox-wallet-app · November 3, 2025 07:16
    2 commits to master
    • @thisconnect ee8e801
      frontend: cleanup and remove sidebar-header-size css variable
    • @thisconnect ec121d9
      frontend: cleanup and remove sidebar-header-line-heigh css variable
    • 1 more commit »
  12. @thisconnect thisconnect opened BitBoxSwiss/bitbox-wallet-app#3663 · October 31, 2025 07:28
    frontend: cleanup css #3663

    In preparation of #3623

    +3 -5
  13. @thisconnect thisconnect created a branch in thisconnect/bitbox-wallet-app · October 31, 2025 14:27
  14. @thisconnect thisconnect pushed to frontend-responsive-fontsize-android in thisconnect/bitbox-wallet-app · October 30, 2025 11:56
    2 commits to frontend-responsive-fontsize-android
  15. @thisconnect thisconnect closed BitBoxSwiss/bitbox-wallet-app#3659 · October 30, 2025 01:39
    frontend: pass ismobile prop to scanqrdialog #3659

    No need to useMediaQuery in scanqrdialog as both parents already do it.

    Before asking for reviews, here is a check list of the most common things y…

    +4 -2
    2 comments
  16. @thisconnect thisconnect pushed to staging-send-to-self-dropdown in BitBoxSwiss/bitbox-wallet-app · October 30, 2025 08:12
    2 commits to staging-send-to-self-dropdown
  17. @thisconnect thisconnect opened BitBoxSwiss/bitbox-wallet-app#3661 · October 29, 2025 07:41
    master into staging-send-to-self merged #3661

    Before asking for reviews, here is a check list of the most common things you might need to consider:

    • updating the Changelog
    • writing unit tests
    +3,421 -1,768
    2 comments
  18. @thisconnect thisconnect opened BitBoxSwiss/bitbox-wallet-app#3659 · October 29, 2025 04:39
    frontend: pass ismobile prop to scanqrdialog #3659

    No need to useMediaQuery in scanqrdialog as both parents already do it.

    Before asking for reviews, here is a check list of the most common things y…

    +4 -2
    2 comments
  19. @thisconnect thisconnect created a branch in thisconnect/bitbox-wallet-app · October 29, 2025 11:38
  20. @thisconnect thisconnect commented on BitBoxSwiss/bitbox-wallet-app#3641 · October 29, 2025 10:04
    A bug we had in past Dialog refactoring was that after editing the 2nd field, the focus jumped to the first input element. Could you test that the …
  21. @thisconnect thisconnect commented on BitBoxSwiss/bitbox-wallet-app#3641 · October 29, 2025 10:03
    The Dialog component will focus the first focusable element inside the dialog. Would it make sense to check focus here and also later after the cha…